Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend/dark): invert weekend/holiday and workday colours #565

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix(frontend/dark): invert weekend/holiday and workday colours #565

merged 1 commit into from
Jan 6, 2025

Conversation

c0rydoras
Copy link
Collaborator

@c0rydoras c0rydoras commented Jan 6, 2025 •
edited
Loading

is this really better?

now:
image

after:
image

@c0rydoras c0rydoras requested a review from a team as a code owner January 6, 2025 16:33
@c0rydoras c0rydoras linked an issue Jan 6, 2025 that may be closed by this pull request
[BUG]: Darktheme: in the date overview weekdays are greyed out while weekends and holidays are white #553
Closed
1 task
@derrabauke
Copy link
Contributor

is this really better?

To me it feels more logical to gray out weekends. So, yes. 👍

@c0rydoras c0rydoras merged commit 5b90151 into adfinis:main Jan 6, 2025
10 checks passed
@c0rydoras c0rydoras deleted the fix/frontend/overview-colours-in-darkmode branch January 6, 2025 16:43
@c0rydoras c0rydoras mentioned this pull request Jan 7, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabauke derrabauke derrabauke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Darktheme: in the date overview weekdays are greyed out while weekends and holidays are white
2 participants
@c0rydoras @derrabauke